merge setup test cassettes #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a single cassette for the whole init/teardown - Use a cassette file name with no white characters If test needs to update the API call it makes, it is easier to only have to re-generate a single file. The spreadsheet creation is done only once but the single sheet is cleared everytime before a new test starts. We must record the spreadsheet creation then close the cassette to allow the fixture `reset_sheet` to find the cassette. Then open it again to record the file deletion. Next time a test needs to be updated and make an extra API call, simplify delete the cassette and run the test recording new episodes. Closes #981
burnash
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify cassette recording for test setup
If test needs to update the API call it makes, it is easier to only have
to re-generate a single file.
The spreadsheet creation is done only once but the single sheet is
cleared every time before a new test starts. We must record the
spreadsheet creation then close the cassette to allow the fixture
reset_sheetto find the cassette. Then open it again to record thefile deletion.
Next time a test needs to be updated and make an extra API call,
simplify delete the cassette and run the test recording new episodes.
Closes #981