Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options object. Specify gulpRelative path. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mccambridge
Copy link

@mccambridge mccambridge commented Oct 19, 2016

I had the same issue a lot of people were having. If I specified a root-relative path in my html, the assets weren't being found and the script errored out.

I created an options obj that allows you to specify a gulpRelative flag, where the script takes a root-relative path and appends it to the pwd. Now it finds the assets even if your html is located in a different directory than the gulpfile. Assets get hashed. Much win.

Fixes: #5 ... maybe others

Cheers!

… for root relative files to consider them gulpfile-relative
@mccambridge
Copy link
Author

looks like you might want to update your node version ;)

@buob
Copy link

buob commented Dec 19, 2016

Thanks for this fix @mccambridge, I hope you're planning on leaving your repo up, I'm hotlinking it until this is merged. 😁

Would this fix require node v4 in order to run if you're using Object.assign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants