Staging website needs favicon different from production

[dwvanstone]

The dev website has a favicon that differs from production. It would be beneficial to have the staging website also have a different favicon from production - it could even match the dev site if need be.

[irilyth]

We talked about this briefly on IRC, and liked the idea of it being different from both dev and prod, and also some things like whether the header should be gray or some other color or what. This seems like a good ticket to tackle those questions. I suggest blue for staging (and leave dev and prod as they are).

[AdmiralJota]

Wouldn't blue make it the same as prod?

My first suggestion would be "take the current prod icon and make it grayscale". But my second suggestion would be "make the staging icon the same as dev". Both of those would require a minimal amount of image manipulation work.

[irilyth]

I think prod is currently black, not blue... If it's secretly a very dark blue, maybe staging could be a light blue?

[irilyth]

#1842 wants to use grayscale for "monitor mode, if you don't have any games to play", so I think we shouldn't use grayscale for staging in any case.

[irilyth]

I think prod is currently black, not blue... If it's secretly a very dark blue, maybe staging could be a light blue?

Huh, check that out, it totally is blue.

Light blue for staging? Orange? I don't have a preference, but would like to do something, so I can keep my tabs straight. :^)

[blackshadowshade]

What about no favicon for the moment? I can certainly rename the favicon to another name as a temporary measure.

[cgolubi1]

I'd like to veto making manual changes to files installed by vagrant on deployed sites. It messes up the deployment process and wastes time.

[cgolubi1]

To suggest an answer to the actual question: is there any reason not to use the dev favicon for the staging site as well?

[blackshadowshade]

Since we're now using staging for the same purpose as our old dev, I think this would be fine.

[irilyth]

I'd said

We talked about this briefly on IRC, and liked the idea of it being different from both dev and prod

I don't recall the details, and am lazy. I think it'd be nice if the mini-dev sites used the dev icon, which I think they don't at the moment.

In any case, here's two yellow versions, as possible staging options:

The first is the prod one with the colors rotated and lightened; the second replaces the "BM" with the darker red from the main site.

If folks like either, I'll put in a PR. If folks have other suggestions, lemme know, keeping in mind that I'm not very good at this. :^)

[irilyth]

To clarify slightly, I think that blue for prod, yellow (or something) for staging, and red for mini-dev, would be better than using red for both staging and mini-dev.

[cgolubi1]

IMO the second one irilyth suggested is just fine; i don't think the bar is high for the graphics on this, and i think it's recognizeably a BM icon.

[blackshadowshade]

If I remember correctly, this requires a change to the database and the UI also?

[irilyth]

Jota seems to have done a bunch of stuff related to the dev favicon in #849, but some of it looks like infrastructure to distinguish the dev and prod sites in general, so I'm not sure what exactly needs to be done to add a third option.

[AdmiralJota]

If you want to set the site up to be able to recognize staging as separate from dev and prod, then I believe there are two code files you'll want to change: Login.js and Overview.js. I've created a gist containing changes that I think should work: https://gist.github.com/AdmiralJota/1dd4f2e734f4c395ec9f1ea9894df2af

(I also updated the link to Cheapass Games, since it looks like our URL for their BM page is out of date. [EDIT: and fixed a typo where we had "you\r" instead of "you're".])

If those two files (and the icon itself) get checked into the main branch, then you should be able to configure the site to be staging by updating the Config.js file; I believe that @cgolubi1's deployment process already has a clause for doing this when pushing to dev.

[cgolubi1]

Okay. So do we think the many-dev-sites should use the dev site icon? I think they should. Anyone disagree?

[Edit: i've gone ahead and made this so, because it's a change in my scripts that setup the many-dev-sites, not in the codebase. But if anyone does object, let me know.]

[blackshadowshade]

Sounds fine to me.

[blackshadowshade]

@AdmiralJota, when I get a free moment today, if Chaos hasn't already done it, I'll put up a pull request with the new URL and the typo change.

[irilyth]

Okay. So do we think the many-dev-sites should use the dev site icon? I think they should. Anyone disagree?

I think they should!

[cgolubi1]

Oops, sorry for the miss there. Thanks, shadowshade.