702 Visually distinguish the dev site from prod

[AdmiralJota]

Resolves #702

http://jenkins.buttonweavers.com:8080/job/buttonmen-AdmiralJota/55/

This will require that puppet overwrite Config.js on the dev site after a deploy.

[AdmiralJota]

Deconflicted.

http://jenkins.buttonweavers.com:8080/job/buttonmen-AdmiralJota/81/

[cgolubi1]

Minor comments:

• Any reason to change the BMInterface and BMInterfaceNewuser $conn variables from private to protected? That looks like part of a change which didn't wind up happening (to add an interface base class), so i'd be inclined not to make that one-liner change either, but it's okay if you want to.
• There's no reason you would have known this without source-diving, but the BMTestUtils.getAllElements() function which gets invoked as pre and post from each test module specifies which JS variable namespaces to query by name. So when you add a new module (Config), you have to add it to that function as well in order for the tests to actually check for unexpected variable changes during execution.

More majorly, i immediately noticed that something is wrong with the login header --- when i'm logged out, there's a lot of unnecessary vertical whitespace in the login header. The old site didn't have this problem:

I never got around to adding real unit tests for Login.js, as you can see from the Cobertura coverage report. I don't want to ask you to fix that entire problem, but, in the interest of using unit tests to prevent regressions of problems we've seen, want to see if it's possible to make a Login.js unit test which catches the extra lines of whitespace in the header while logged out?

Otherwise, the dev favicon and grayed header look fine to me. I am not super fond of all-caps and think the gray will be obvious enough, so i would just say "ButtonMen Dev Site" in the header (i think it makes sense on the front page), but don't feel strongly.

I'll write the puppet config to change Config.js on the dev site.

[AdmiralJota]

http://jenkins.buttonweavers.com:8080/job/buttonmen-AdmiralJota/88/

There's still some added whitespace in the header (both when you're logged in and when you're not), since A) the grey background needs it to not look weird, and B) I wanted to keep the header the same height whether it's dev or prod, but it's no longer egregious or aesthetically inappropriate, I don't think.

Unfortunately, I don't think that the way CSS renders whitespace is something we can test for in javascript unit tests.

I've made the other changes.

[cgolubi1]

Thanks! I agree the whitespace looks better now. Merging.