-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python versions #117
Conversation
Edit: Python 2.6 support is no longer an issue for gcovr. My points about breaking downstream modules still hold, but I no longer have a horse in this race. I am currently evaluating the use of ConfigArgParse for the gcovr tool. If this PR is merged and ConfigArgParse drops support for Python 2.6, I will have to find a different way to deal with config files. I understand the desire to move to modern Python. However, some operating systems (CentOS 6) are still stuck on Python 2.6. CentOS 6 will be EOL'ed after Nov 2020. I have no desire to break hundreds of downstream users unless continuing to support 2.6 would require excessive effort. This PR doesn't seem to provide any substantial value that would be impossible with continued support for Python 2.6. I would therefore suggest that the PR is not merged in its current form – although some of the small fixes and enhancements are nice and can be rebased/cherry-picked independently. |
I wouldn't say CentOS 6 is stuck on Python 2.6, I understand upgrading Python is officially supported by CentOS via the Software Collections Repository.
https://wiki.centos.org/AdditionalResources/Repositories/SCL And if upgrading from an old Python is unsuitable, pinning to an old release of this library is easily doable, as is already needed with other libraries for a 5-years-insecure 2.6. Some Python libraries are already planning how to drop Python 2.7, which will be EOL on 2020-01-01. See also:
|
Updated to add |
I like the changes in this PR, but it seems to me they're not necessary for any actual functionality. On the other hand, if there are 1+ users that still need python 2.6 for whatever reason, then merging it has negative value. |
How many people still want python2.6 support? (@latk ) |
@bw2 In the meanwhile I've dropped Python 2.6 support from gcovr, and have also decided to not use ConfigArgParse. As far as I am concerned, happy merging to you :) |
3f93ca8
to
6267759
Compare
I'm ok to merge that. @bw2 ? |
Here's the pip installs for ConfigArgParse from PyPI for May 2019:
Source: |
Python 2.6, 3.2 and 3.3 are EOL and no longer receiving security updates.
They're also little used if at all.
Here's the pip installs for ConfigArgParse from PyPI for last month:
Source:
pypinfo --start-date -46 --end-date -19 --percent --pip --markdown ConfigArgParse pyversion
This removes those, and updates the code to use more modern Python features. It also adds Python 3.6.