Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CargoArguments::parse_from public #375

Merged

Conversation

greenhat
Copy link
Contributor

@greenhat greenhat commented Mar 3, 2025

To allow using cargo-component as a library.

@greenhat
Copy link
Contributor Author

greenhat commented Mar 3, 2025

I checked the failing CI tests, and found that they are triggered by the new Rust edition. Seems to be they should be fixed by bytecodealliance/wit-bindgen#1183.

@pchickey
Copy link
Contributor

pchickey commented Mar 3, 2025

Thanks. Once the CI fix lands you could push a merge or rebase to get CI to run properly

@greenhat
Copy link
Contributor Author

greenhat commented Mar 5, 2025

Thank you! Will do.

@pchickey
Copy link
Contributor

I just got the 2024 edition stuff fixed on main.

To allow using `cargo-component` as a library.
@greenhat greenhat force-pushed the pub-cargo-arguments-parse-from branch from 8eb0bf0 to 4b3046b Compare March 14, 2025 08:25
@greenhat
Copy link
Contributor Author

@pchickey Thanks! Rebased.

@pchickey pchickey merged commit 1fc82ee into bytecodealliance:main Mar 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants