Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NO_AUTOMOUNT AtFlags, STATX_DIOALIGN mask and reorder bitflag to follow numbering #523

Merged
merged 3 commits into from
Jun 17, 2023

Conversation

ETKNeil
Copy link
Contributor

@ETKNeil ETKNeil commented Jan 19, 2023

The statx syscall accept the AT_NO_AUTOMOUNT flag , however this one was not listed inside the AtFlags bitflag.
This PR add such flag from the underlying raw types, it also re-orders the bitflag to be in correlation with the underlying values.

The statx syscall accept the STATX_DIOALIGN mask since Linux 6.1 however this one was not listed inside the StatxFlags bitflag.
This PR add such flag from the underlying raw types.

Note, can_compile signature in build.rs was changed on the 13th of January and you can remove the reference to format (thx clippy)

@ETKNeil ETKNeil changed the title Add NO_AUTOMOUNT AtFlags and reorder bitflag to follow numbering Add NO_AUTOMOUNT AtFlags, STATX_DIOALIGN mask and reorder bitflag to follow numbering Jan 19, 2023
@ETKNeil
Copy link
Contributor Author

ETKNeil commented Jan 19, 2023

this will need to add first STATX_DIOALIGN to libc (rust-lang/libc#3076)

@sunfishcode
Copy link
Member

This looks good to me, so now it's just waiting on the libc PR.

@sunfishcode
Copy link
Member

The libc PR here landed and is released as of libc 0.2.140, so now this just needs a rebase.

@sunfishcode sunfishcode force-pushed the add-no-automount-atflags branch from 7e9c8f3 to 03ab077 Compare June 16, 2023 22:46
@sunfishcode sunfishcode merged commit fbd0f2d into bytecodealliance:main Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants