Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade wasm-tools to 0.224 #146

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Upgrade wasm-tools to 0.224 #146

merged 4 commits into from
Jan 31, 2025

Conversation

lann
Copy link
Collaborator

@lann lann commented Jan 31, 2025 •
edited
Loading

  • BREAKING: Integrate upstream metadata overhaul. The set of fields available changed, meaning this may break some existing config files.
  • Adapt to changed WitPrinter interface
  • Update targets to wasm32-wasip1

This was referenced Jan 31, 2025
Closed
Merged
@lann
Upgrade wasm-tools to 0.224
2f1d675 
- Integrate upstream metadata overhaul
- WitPrinter interface change
@lann lann force-pushed the upgrade-wasm-tools branch from 0aa9a5e to 2f1d675 Compare January 31, 2025 16:01
@lann lann requested a review from thomastaylor312 January 31, 2025 16:01
thomastaylor312
thomastaylor312 requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two discussion items around the breaking changes

@lann lann merged commit c6bd2aa into bytecodealliance:main Jan 31, 2025
3 checks passed
@lann lann deleted the upgrade-wasm-tools branch January 31, 2025 19:07
@yoshuawuyts yoshuawuyts mentioned this pull request Feb 13, 2025
Merged
@yoshuawuyts yoshuawuyts mentioned this pull request Feb 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lann @thomastaylor312