Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in binary representation of future and error-context #2044

Closed
cpetig opened this issue Feb 9, 2025 · 1 comment
Closed

Discrepancy in binary representation of future and error-context #2044

cpetig opened this issue Feb 9, 2025 · 1 comment

Comments

@cpetig
Copy link
Contributor

cpetig commented Feb 9, 2025

Probably because WebAssembly/component-model#384 was merged a few weeks before WebAssembly/component-model#405 , the component model binary specification defines futures as 0x65 and error-contexts as 0x64.

Wasm-tools on the other hand uses future 0x67 and error-context 0x65. I guess the implementation predates the spec.

Both agree on streams as 0x66.

I can create a PR to make wasm-tools follow the spec, but I would like to clarify that this is indeed the right path.

PS: I found this problem while implementing fixed size lists in #1992 ...

@alexcrichton
Copy link
Member

Fixed in #2045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants