[wasm-metadata] print relationships #2075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to #2074, this adds child relationships to the printed output of
wasm-metadata
. This should make it easier to understand what the relationship is between the various payloads in the binary.On a quick aside here: together with #2058 and #1924 we're on track to significantly increase the amount of data printed by
wasm-metadata
. I don't think this is a bad thing per se - all of this info is useful. But we may want to rethink exactly how we're printing that data in the longer term. Perhaps by providing summary tables, or separate commands to drill down into specifics, and so on. Nothing to do here now, but I wanted to acknowledge that this will eventually become a concern.Thanks!
Example