Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Step 3 - Use the db in async mode #21

Merged
merged 5 commits into from
Jul 16, 2023
Merged

Async Step 3 - Use the db in async mode #21

merged 5 commits into from
Jul 16, 2023

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Jul 15, 2023

  • Use sqlalchemy async apis for accessing the database
  • For tests:
    • Continue to use mocked_session, a synchronous session, for factory-boy (which doesn't yet support async apis)
    • Use an AsyncSession for the rest of tests where we call our app code.

@caarmen caarmen force-pushed the use-async-db branch 3 times, most recently from 05a9596 to d017d2a Compare July 15, 2023 22:32
@caarmen caarmen changed the title Async Step 2 - Use the db in async mode Async Step 3- Use the db in async mode Jul 15, 2023
@caarmen caarmen marked this pull request as ready for review July 15, 2023 23:11
@caarmen caarmen changed the title Async Step 3- Use the db in async mode Async Step 3 - Use the db in async mode Jul 15, 2023
@caarmen caarmen mentioned this pull request Jul 16, 2023
Merged
Base automatically changed from use-async-httpx to use-async-apis July 16, 2023 14:40
@caarmen caarmen merged commit e7b7735 into use-async-apis Jul 16, 2023
@caarmen caarmen deleted the use-async-db branch July 16, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caarmen