Add Fitbit spinning activities #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarmen
force-pushed
the
add-fitbit-spinning-activities
branch
3 times, most recently
from
af9a04f to
b167052
Compare
caarmen
force-pushed
the
add-fitbit-spinning-activities
branch
4 times, most recently
from
f3d20e4 to
27f818b
Compare
When the fitbit notification webhook notifies us of a spinning activity, fetch it and post it to slack if it's a new activity. This requires: * A new column in the database, `last_activity_log_id`, to make sure we don't post activities multiple times. * A new scope to be able to fetch activities from fitbit. For now, only process activities of type "Spinning". Add the activity fetching to the polling as well.
caarmen
force-pushed
the
add-fitbit-spinning-activities
branch
from
27f818b to
f1c1b0e
Compare
caarmen
force-pushed
the
add-fitbit-spinning-activities
branch
from
4d3214d to
62593d2
Compare
caarmen
changed the title
caarmen
force-pushed
the
add-fitbit-spinning-activities
branch
from
62593d2 to
1b7a773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #25
Preparation:
Then the new feature: Add Fitbit spinning activities.
When the fitbit notification webhook notifies us of a spinning activity, fetch it and post it to slack if it's a new activity.
This requires:
last_activity_log_id, to make sure we don't post activities multiple times.For now, only process activities of type "Spinning".
Add the activity fetching to the polling as well.
Add tests for fitbit activities (polling and notificaiton webhook)