Various fixes to incoming webhooks for withings/fitbit notifications #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `test_first_user_weight` initially only tested a scenario where no previous weight was logged. It was modified after to test different scenarios. Updating the test name and inline comments to reflect that.
It currently fails because we don't correctly save the sleep data.
…bhook was called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix naming and comments in test_withings_routes:
The test
test_first_user_weightinitially only tested a scenario where no previous weight was logged. It was modified after to test different scenarios. Updating the test name and inline comments to reflect that.Extract test scenarios out of test_fitbit_poll into fitbit_scenarios.
Add a test for the fitbit notification webhook.
It currently fails because we don't correctly save the sleep data.
Fix bug where sleep data wasn't saved when the fitbit notification webhook was called.