Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring preparation to show progress of fitbit activities #33

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Refactoring preparation to show progress of fitbit activities #33

merged 3 commits into from
Aug 14, 2023

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Aug 6, 2023 •
edited
Loading

  • Define an enum for the activity zone, instead of using the zoneName from the fitbit api directly.
    This will help us to refer to specific column names of the future activities table, like cardio_minutes or fat_burn_minutes.
  • Remove some assertions from unit tests that are redundant with factory tests.

@caarmen caarmen force-pushed the issue-31-refacto-prepare-fitbit-activity-progress branch from 7684c33 to 71e285d Compare August 6, 2023 18:00
@caarmen caarmen merged commit 4e8a39d into main Aug 14, 2023
@caarmen caarmen deleted the issue-31-refacto-prepare-fitbit-activity-progress branch August 14, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caarmen