Keep a log of all activities, not just the latest activity for each activity type. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarmen
changed the title
caarmen
force-pushed
the
keep-all-activities
branch
2 times, most recently
from
7b42c0a to
c73018e
Compare
caarmen
commented
Jan 21, 2024
caarmen
force-pushed
the
keep-all-activities
branch
from
c73018e to
f2e0301
Compare
caarmen
commented
Jan 21, 2024
caarmen
force-pushed
the
keep-all-activities
branch
3 times, most recently
from
c11e779 to
d91f2a7
Compare
…ivities`. Copy all the fields and the data. Don't copy the unique constraint on user + activity type. We'll now log all the users' activities for each supported type, not just one per user and type. Add a db migration which: * creates the new table. * populates the new table with the data from the old table. * deletes the old table. Add a crud function to get the latest activity for a given user and type. * Use this crud function from the fitbit service, to get the latest activity. * Use this crud function from tests, to verify that we correctly inserted a new activity. Add a crud function to get the activity for a user with a given log id. * Use this from the fitbit service, when checking if an activity exists already. Remove `relationship`s between `FitbitUser` and `FitbitActivity`, to avoid loading all activities for a user. Add `created_at` and `updated_at` fields to test fixtures, so we can be sure our pre-existing activity data exists with timestamps in the past. Otherwise, the pre-existing activities will be created with the same timestamp (the resolution is seconds) as the new ones created, and the db query to get the latest activity may not always return the new activities.
caarmen
force-pushed
the
keep-all-activities
branch
from
d91f2a7 to
ca112dd
Compare
caarmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy all the fields and the data. Don't copy the unique constraint on user + activity type. We'll now log all the users' activities for each supported type, not just one per user and type.
Add a db migration which:
Add a crud function to get the latest activity for a given user and type.
Add
created_atandupdated_atfields to test fixtures, so we can be sure our pre-existing activity data exists with timestamps in the past. Otherwise, the pre-existing activities will be created with the same timestamp (the resolution is seconds) as the new ones created, and the db query to get the latest activity may not always return the new activities.