-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trophies to activity records, in slack messages #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarmen
commented
Feb 11, 2024
5f4d377
to
bfb7379
Compare
caarmen
commented
Feb 13, 2024
c38bc57
to
a5f49b1
Compare
We don't need to do any validation or parsing for these objects.
this approach feels wrong. Will sleep on it...
…ages, BUT" This reverts commit e685b3b.
a3eeceb
to
a5a2aee
Compare
…estable separately from the message sending
a5a2aee
to
8ac1376
Compare
caarmen
commented
Feb 17, 2024
8ac1376
to
242b64c
Compare
242b64c
to
b2949c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Changes:
process_new_activity
usecase to use this new function and provide the info to the slackusecase_post_activity
.usecase_post_activity
to include the medals in the message.