Fix various pycharm warnings. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarmen
force-pushed
the
top-activities
branch
from
a5a2aee to
8ac1376
Compare
caarmen
force-pushed
the
top-activities
branch
2 times, most recently
from
242b64c to
b2949c0
Compare
caarmen
force-pushed
the
fix-pycharm-warnings
branch
from
1875171 to
b57962e
Compare
caarmen
commented
Mar 2, 2024
| from slackhealthbot.data.repositories import fitbitrepository | ||
|
|
||
|
|
||
| def repository_oauth_to_core_oauth( |
There was a problem hiding this comment.
Will maybe refactor the archi (again 😅 🙄 ), and use domain models from use cases and repositories. That should hopefully mean fewer mapper classes to maintain.
caarmen
force-pushed
the
fix-pycharm-warnings
branch
4 times, most recently
from
297ff2f to
546e091
Compare
caarmen
commented
Mar 2, 2024
* Fix some type hints * Suppress warning about acessing `_asdict()` in sqlalchemy. It's [documented](https://docs.sqlalchemy.org/en/20/core/connections.html#sqlalchemy.engine.Row._asdict). * Avoid using `input` as a variable/argument name, as it's a built-in symbol. * Define a method as `@staticmethod` if it doesn't need to access any class or instance fields. * Convert str explicitly to `ActivityZone` enum instances, where enum instances are expected.
caarmen
force-pushed
the
fix-pycharm-warnings
branch
from
546e091 to
374c552
Compare
caarmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_asdict()in sqlalchemy. It's documented.inputas a variable/argument name, as it's a built-in symbol.@staticmethodif it doesn't need to access any class or instance fields.Add missingFixed in Add tests for oauth flows during fitbit polling (and fix bug about missingawaitbefore a call of an async function.await). #61ActivityZoneenum instances, where enum instances are expected.