Issue #63: Architecture refacto: inversion of repository/domain dependency #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarmen
force-pushed
the
issue-63-refactor-archi
branch
7 times, most recently
from
c50e65c to
74d1122
Compare
In an attempt to be a bit closer to more common clean archi practices: * Introduce `WithingsRepository` as an abstract class * Introduce `WithingsDbRepository` as a concrete class which implements `WithingsRepository`. The implementation is mostly what the previous `withingsrepository` module did. * Provide an instance of `WithingsDbRepository` to the use cases, instead of providing an instance of `AsyncSession`. * Remove mappers between (old) repo objects and domain objects. ithings
In an attempt to be a bit closer to more common clean archi practices: * Introduce `FitbitRepository` as an abstract class. * Introduce `FitbitDbRepository` as a concrete class which implements `FitbitRepository`. The implementation is mostly what the previous `fitbitrepository` module did. * Provide an instance of `FitbitDbRepository` to the use cases, instead of providing an instance of `AsyncSession`. * Remove mappers between (old) repo objects and domain objects.
We don't use AsyncAttrs anymore since we introduced repositories.
caarmen
force-pushed
the
issue-63-refactor-archi
branch
from
530b19c to
0e5eb61
Compare
caarmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #63
In an attempt to be a bit closer to more common clean archi practices:
WithingsRepositoryas an abstract classWithingsDbRepositoryas a concrete class which implementsWithingsRepository. The implementation is mostly what the previouswithingsrepositorymodule did.WithingsDbRepositoryto the use cases, instead of providing an instance ofAsyncSession.Similar changes for fitbit.