Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert dependency between remote services and domain #66

Merged
merged 7 commits into from
Mar 17, 2024
Merged

Invert dependency between remote services and domain #66

merged 7 commits into from
Mar 17, 2024

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Mar 11, 2024 •
edited
Loading

Issue #65

  • Add RemoteRepositoryInterfaces in the domain layer.
  • Add RemoteRepositories in the remote services layer.
  • Make the RemoteRepositories depend on (implement) the RemoteRepositoryInterfaces.
  • Make the use cases depend on (use) the RemoteRepositoryInterfaces.

@caarmen caarmen force-pushed the issue-65-invert-remoteservices-domain-dependency branch 4 times, most recently from 7414644 to c2a8cf2 Compare March 16, 2024 14:54
@caarmen caarmen changed the title Update architecture schema with target architecture. Invert dependency between remote services and domain Mar 16, 2024
@caarmen caarmen force-pushed the issue-65-invert-remoteservices-domain-dependency branch 4 times, most recently from 5a9f6bc to c8f4e30 Compare March 16, 2024 16:53
caarmen added 6 commits March 16, 2024 17:54
@caarmen
Update architecture schema with target architecture.
1669573 
Add RemoteRepositoryInterfaces in the domain layer.
Add RemoteRepositories in the remote services layer.
Make the RemoteRepositories depend on the RemoteRepositoryInterfaces.
@caarmen
Rename modules and classes related to the data/repository layer.
fd5b236 
* FitbitRepository -> LocalFitbitRepository
* WithingsRepository -> LocalWithingsRepository
* FitbitDbRepository -> SQLAlchemyFitbitRepository
* WithingsDbRepository -> SQLAlchemyWithingsRepository
@caarmen
Move remoteservices api classes to a submodule api.
0ca571a
@caarmen
Introduce RemoteSlackRepository.
663561d 
Use this repository interface from use cases, instead of calling the services directly.
@caarmen
Introduce RemoteWithingsRepository.
14c4f67 
Use this repository interface from use cases, instead of calling the services directly.
@caarmen
Introduce RemoteFitbitRepository.
604b6d4 
Use this repository interface from use cases, instead of calling the services directly.
@caarmen caarmen force-pushed the issue-65-invert-remoteservices-domain-dependency branch from c8f4e30 to 604b6d4 Compare March 16, 2024 16:54
@caarmen caarmen marked this pull request as ready for review March 17, 2024 00:54
@caarmen caarmen merged commit eb1f58f into main Mar 17, 2024
2 checks passed
@caarmen caarmen deleted the issue-65-invert-remoteservices-domain-dependency branch March 17, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caarmen