-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity aggregation #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed coverage is Generated by 🐒 cobertura-action against b30e0e0 |
7708ee8
to
425ac6c
Compare
d220864
to
14fb2a9
Compare
7b8130c
to
a6a0c48
Compare
caarmen
commented
Aug 11, 2024
ff053aa
to
086cdc0
Compare
caarmen
commented
Aug 13, 2024
slackhealthbot/domain/usecases/fitbit/usecase_process_daily_activities.py
Show resolved
Hide resolved
caarmen
commented
Aug 13, 2024
slackhealthbot/domain/usecases/fitbit/usecase_process_daily_activity.py
Outdated
Show resolved
Hide resolved
caarmen
commented
Aug 13, 2024
086cdc0
to
9758569
Compare
3d83da3
to
cb5f498
Compare
…a seprate module.
Add some `None` checks inside the funtions, so callers don't have to do these checks.
…ecific user and activity type, before a certain date.
…a given user and activity type.
f9d276f
to
4595a4f
Compare
Create, in the db, activities for both realtime and daily activity type ids. Only post a message to slack for realtime activities.
4595a4f
to
b30e0e0
Compare
caarmen
commented
Aug 18, 2024
Comment on lines
+23
to
+25
FITBIT_REALTIME_ACTIVITY_TYPE_IDS=[55001, 90013] | ||
FITBIT_DAILY_ACTIVITY_TYPE_IDS=[90019] | ||
FITBIT_DAILY_ACTIVITY_POST_TIME=23:50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change:
- Removed setting:
FITBIT_ACTIVITY_TYPE_IDS
- Added settings:
FITBIT_REALTIME_ACTIVITY_TYPE_IDS
FITBIT_DAILY_ACTIVITY_TYPE_IDS
FITBIT_DAILY_ACTIVITY_POST_TIME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fitbit_daily_activities
DB view.fitbit_activities
data.DailyActivityStats
for a given user and activity typeDailyActivityStats
, find the previous, all-time top, and recent top daily activity stats, and pass it to the new slack use case.DailyActivityStats
object to slack.FITBIT_ACTIVITY_TYPE_IDS
FITBIT_REALTIME_ACTIVITY_TYPE_IDS
FITBIT_DAILY_ACTIVITY_TYPE_IDS
FITBIT_DAILY_ACTIVITY_POST_TIME
Example of new settings: