Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "out of range" to "out of zone". Don't crash on unknown zones. #79

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Sep 6, 2024

The fitbit api documentation notes the valid values for `activeZoneMinutes` `type`: https://dev.fitbit.com/build/reference/web-api/activity/get-activity-log-list/#Response
Copy link

github-actions bot commented Sep 6, 2024

File Coverage
All files 98%
logger.py 91%
main.py 97%
data/database/connection.py 92%
domain/localrepository/localwithingsrepository.py 94%
domain/usecases/slack/usecase_post_daily_activity.py 94%
domain/usecases/slack/usecase_post_sleep.py 97%
remoteservices/api/withings/subscribeapi.py 83%
remoteservices/api/withings/weightapi.py 93%
remoteservices/repositories/webapifitbitrepository.py 97%
routers/dependencies.py 85%
tasks/fitbitpoll.py 96%
tasks/post_daily_activities_task.py 92%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 59efb3c

@caarmen caarmen changed the title Rename "out of range" to "out of zone". Rename "out of range" to "out of zone". Don't crash on unknown zones. Sep 6, 2024
@caarmen caarmen marked this pull request as ready for review September 6, 2024 10:02
@caarmen caarmen merged commit a1d4a0c into main Sep 6, 2024
3 checks passed
@caarmen caarmen deleted the fix-out-of-zone branch September 6, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant