Create jinja_report tryton module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMSoler7
force-pushed
the
init_project
branch
from
35c8075 to
4f93c28
Compare
GuillemCalidae
approved these changes
Jan 17, 2022
maltalk
requested changes
Jan 17, 2022
.github/workflows/tests.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| python-version: [3.9] |
There was a problem hiding this comment.
We could set more versions from 3.8 to 3.10 for example. Or at least the same versions stated in the setup.py classifiers block.
There was a problem hiding this comment.
And those should be present in the tox.ini test matrix as well
JMSoler7
force-pushed
the
init_project
branch
from
4f93c28 to
d9f4652
Compare
JMSoler7
force-pushed
the
init_project
branch
2 times, most recently
from
d4fa82f to
1249f2d
Compare
maltalk
approved these changes
Jan 20, 2022
n1ngu
reviewed
Jan 20, 2022
.github/workflows/tests.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| python-version: [3.8, 3.9] |
There was a problem hiding this comment.
Watchout actions/setup-python#249 (comment) to support python-3.10
There was a problem hiding this comment.
Thanks! Now is already fixed
This is the first commit which contains everything is need to create a tryton report based on jinja2 with just installing this module and override Jinja2Report class. This commit set up: - Jinja2Report class to create new reports and SetTranslationJinja2 class to create translations. - Files related to wheel package such as setup, manifest, License, etc. - Readme in order to understand how to use this module - Simple test which checks that is possible to override Jinja2Report and obtain a rendered html - Tox with test and linting processes - Github actions with launch tox on a PR to a master - Github actions to wheel package and upload to pypi when a tagged commit arribes to origin
JMSoler7
force-pushed
the
init_project
branch
from
1249f2d to
d30ae11
Compare
n1ngu
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit which contains everything is need to create a tryton report based on jinja2 with just
installing this module and override Jinja2Report class. This commit set up: