feat: remove multiple bundle builds #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HumbertoL
force-pushed
the
single-bundle-scripts
branch
2 times, most recently
from
49c27a8 to
d9aa529
Compare
aywgit
reviewed
Apr 4, 2024
| minify: false, | ||
| cache: false, | ||
| }); | ||
| // *** Call-Em-All Text-Em-All Web App |
There was a problem hiding this comment.
May want to keep this line 161 to indicate end of our additions in this block. Just // *** Text-Em-All Web App
aywgit
reviewed
Apr 4, 2024
packages/react-scripts/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "tea-react-scripts", | |||
| "version": "1.0.16", | |||
| "version": "1.0.17", | |||
There was a problem hiding this comment.
Thanks! Change pushed
HumbertoL
force-pushed
the
single-bundle-scripts
branch
from
d9aa529 to
98c6bea
Compare
|
Shoot. I meant to merge the cea-desktop PR 🤦 I'll still address any feedback provided by Mike |
|
It's all good. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strips out the different entry points used to build cea-desktop. This change the build to have a single bundle that instead uses lazy loading to split chunks.
This other PR makes the necessary changes to cea-desktop to support a single bundle:
https://github.com/callemall/cea-desktop/pull/9820
To view all the changes in tea-react-scripts compared to the vanilla react-scripts, you can compare this branch to the official CRA repo
facebook/create-react-app@main...callemall:create-react-app:single-bundle-scripts