cleanup: Use switch for error enum instead of string array.
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `switch` will cause compiler warnings when missing enumerators. The array as it was written will produce `NULL` for missing errors (no out of bounds, because of the `MAX + 1` size). Also, prefixed the errors with `CMP_ERROR_` to namespace all the enumerators into the `cmp_error_t` enum namespace.
|
Ha did I really not prefix those, yeesh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
switchwill cause compiler warnings when missing enumerators. The array as it was written will produceNULLfor missing errors (no out of bounds, because of theMAX + 1size).Also, prefixed the errors with
CMP_ERROR_to namespace all the enumerators into thecmp_error_tenum namespace.