Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #777 preserve newline character for narratives #838

Merged
merged 5 commits into from
Nov 10, 2021

Conversation

Ancentury
Copy link
Contributor

No description provided.

@Ancentury Ancentury requested a review from MrDeshaies November 7, 2021 22:59
@Ancentury Ancentury linked an issue Nov 7, 2021 that may be closed by this pull request
@MrDeshaies
Copy link
Contributor

Hi @Ancentury, browser.js is a local copy of an imported library. Can you please clarify how it was updated (where it was sourced from), or what changes were made? Thanks.

@Ancentury
Copy link
Contributor Author

@MrDeshaies This is updated from their cdn https://cdn.jsdelivr.net/npm/html-to-pdfmake/browser.js, I suggest to include this in the package instead of linking from index.html.

@MrDeshaies
Copy link
Contributor

MrDeshaies commented Nov 9, 2021

In testing, only the translations show up correctly; the original input captured in the survey.js form does not.
newlines_test_json.txt

For example, if I do everything in English: complete the AIA in English (screens 1-13), then complete to view the results. The initial input does not keep new lines when viewing the English results or English PDF.

It's likely the other outputs in TextResult.vue need to receive the span with style as well, e.g. lines 31, maybe 15.

@Ancentury
Copy link
Contributor Author

@MrDeshaies You're right. Thank you. Updated. :)

@MrDeshaies MrDeshaies merged commit 3783310 into master Nov 10, 2021
@MrDeshaies MrDeshaies deleted the 777-preserve-newline branch November 10, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve newline character for narratives
2 participants