776 add question help #890
Conversation
|
The current button to show help is too prominent, it is too big and loud. Instead, it should be a small neutral icon so as to not attract undue attention.
An "i" in a circle is a popular tooltip/help icon. Could something like this be used instead? |
|
Changed to "i" icon. Please check again. |
The icon looks good :) |
|
There's a bug. When there are more than two questions in the same section with help text, all questions display the help for the last question. I think Home.vue, line 161, is the problem.
This should be done in the handler showHelp() defined in index.html, not as part of rendering the questions for the section in Home.vue. |
|
Nice catch. Fixed. Please check again. |
| helpTxt = helpTxt | ||
| .replace(/&/g, '&') | ||
| .replace(/"/g, '"') | ||
| .replace(/'/g, 'ooooo') |
There was a problem hiding this comment.
Not sure this escape makes sense. I think this replace section should just be using something like https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent
There was a problem hiding this comment.
Good eye. This escape is similar to encodeURIComponent, but add some more escape, and work around.
No description provided.