Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

808 score breakdown #896

Merged
merged 9 commits into from
Jan 24, 2022
Merged

808 score breakdown #896

merged 9 commits into from
Jan 24, 2022

Conversation

Ancentury
Copy link
Contributor

No description provided.

@Ancentury Ancentury requested a review from MrDeshaies January 23, 2022 18:19
@Ancentury Ancentury self-assigned this Jan 23, 2022
@Ancentury Ancentury linked an issue Jan 23, 2022 that may be closed by this pull request
Score breakdown by section in results #808
Closed
MrDeshaies
MrDeshaies reviewed Jan 23, 2022
View reviewed changes
src/views/Results.vue Outdated
let totalProjectScore = 0;
let totalMaxScore = 0;
if (this.myResults[1]?.length > 0) {
this.myResults[1].forEach((myResult) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me?

ERROR in aia-eia-js/src/views/Results.vue(300,34):
300:34 Parameter 'myResult' implicitly has an 'any' type.

MrDeshaies
MrDeshaies reviewed Jan 23, 2022
View reviewed changes
@MrDeshaies
Copy link
Contributor

At first glance, it works and looks pretty good! I found two minor issues:

  1. In French, the headers Risk Area, No Of Questions, Project Score, etc., and the final total row RAW IMPACT SCORE and MITIGATION SCORE are not translated.
  2. From the result page, loading a new json doesn't refresh the scores in the tables. This is how I achieved the screenshot below, showing a "code d'incidence brute" (raw impact score) of 47, but in the table it is shown as 4.
    image

@MrDeshaies
Copy link
Contributor

One more thing: within the Mitigation section, the table header "Risk Area" should be changed to "Mitigation Area". Thanks!
image

@Ancentury
Copy link
Contributor Author

Good catch. I will update.

  1. For the translations. Do you use any specified translations or do I just google it?
  2. I will fix Loading a new json doesn't refresh issue as soon as possible.
  3. For the Mitigation section, I just create words similar to Risk Area :) as there is no table instruction. Do you have any specified translations too?
    Thank you for finding these.

@MrDeshaies
Copy link
Contributor

MrDeshaies commented Jan 23, 2022 •
edited
Loading

  1. For the translations. Do you use any specified translations or do I just google it?
  2. For the Mitigation section, I just create words similar to Risk Area :) as there is no table instruction. Do you have any specified translations too?

Tables 3 and 4 on this page can provide the translations.

  • Risk Area: Secteur de risque
  • No. of questions: Nombre de questions
  • Project Score: Cote du projet
  • Maximum Score: Cote maximale
  • Mitigation Area: Secteur d’atténuation
  • RAW IMPACT SCORE: COTE D'INCIDENCE BRUTE
  • MITIGATION SCORE: COTE D'ATTÉNUATION

Let me know if you need other ones, or create placeholders in fr.json and I can populate them.

@Ancentury
Copy link
Contributor Author

Thank you for providing the translations. The project is updated. Please check again.

@MrDeshaies MrDeshaies merged commit 5137afd into master Jan 24, 2022
@MrDeshaies MrDeshaies deleted the 808-score-breakdown branch January 24, 2022 19:41
@MrDeshaies MrDeshaies mentioned this pull request Jan 28, 2022
Closed
@MrDeshaies
Copy link
Contributor

This PR will need a little more work. The tables always come out empty in deployed versions of the code (like here: https://canada-ca.github.io/aia-eia-js/). I added some details in #808

@MrDeshaies MrDeshaies restored the 808-score-breakdown branch January 29, 2022 16:30
@MrDeshaies
Copy link
Contributor

Fixed with #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrDeshaies MrDeshaies MrDeshaies approved these changes

Assignees

@Ancentury Ancentury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Score breakdown by section in results
2 participants
@Ancentury @MrDeshaies