Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test reference to test ckf 1.9 and mlflow 2.15 #1195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jan 15, 2025

This PR updates the test-reference/versions.json file to reflect the CKF and CMLFlow version matrix that should be tested.

Copy link
Contributor

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DnPlas! Small question regarding K8s version and a suggestion for juju version

@@ -87,26 +85,25 @@
"k8s": {
"charmed-kubernetes": {
"min-supported": "1.24",
"max-supported": "1.29"
"max-supported": "1.30"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Should we bump this to 1.31 or even higher to experiment?

@mvlassis do you know what is the version upstream is targeting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this a bit with @kimwnasptd:

  • The dependency version list initially listed up to 1.32-1.33 (1.33 is not out as of writing this), and after asking for disambiguation I received as an answer "up to version 1.31", see here
  • The kubeflow/manifests repo tests each component individually with 1.32, see the relevant script.
  • The release blog post (drafting as of writing this comment) mentions support for 1.32

Given the above, we could add 1.32 as the maximum supported version

},
"eks": {
"min-supported": "1.24",
"max-supported": "1.29"
"max-supported": "1.30"
}
},
"juju": {
"current-edge": "3.4/edge",
"current-stable": "3.4/stable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (blocking): This seems like an outdated version of JuJu

Let's change it to 3.6 as it's also what we test now on repos and UATs
https://github.com/canonical/bundle-kubeflow/blob/585e78f5dddf68a923f431d4354de445d4ffd493/.github/dependencies.yaml

},
"aks": {
"min-supported": "1.27",
"max-supported": "1.29"
"max-supported": "1.30"
},
"eks": {
"min-supported": "1.24",
Copy link
Contributor

@kimwnasptd kimwnasptd Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(blocking): This EKS version is no longer supported.

Let's update the min-K8s versions to something higher like 1.27? But let me know if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants