Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove product with video and ratings #1982

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove product with video and ratings #1982

wants to merge 1 commit into from

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Dec 24, 2024 •
edited
Loading

Identical with video product I dono why there was issues creating productVideoWithRatings this instance but video product cud be created

The error was worker: encountered error indexing card instance ProductWithVideoAndRatings/76529ed3-1c08-4644-9f6f-c392f9254b32.json: bug: could not identify card: Object

There is already a catalog entry for video product

@tintinthong tintinthong requested review from burieberry and a team December 24, 2024 17:20
@github-actions GitHub Actions
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   20m 30s ⏱️ +15s
718 tests ±0  716 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
723 runs  ±0  721 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit c32dd96. ± Comparison against base commit 175a4d1.

burieberry
burieberry approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@burieberry burieberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove but the difference is this one also has a ratings-summary field. Is there an error in ratings-summary?

@tintinthong
Copy link
Contributor Author

tintinthong commented Jan 6, 2025 •
edited
Loading

This errors out bcos you don't have ratingsSummary inside of the json field data when creating a card since ratingsSummary is a computed. I think there is an opportunity to understand why this problem occurs so I am investigating this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemelia lukemelia lukemelia approved these changes

@burieberry burieberry burieberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tintinthong @lukemelia @burieberry