Allow field def containedExamples to render #2178
Draft
+472
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintinthong
changed the title
tintinthong
force-pushed
the
cs-7929-render-contained-example-in-spec
branch
from
3180076 to
0cf9e05
Compare
tintinthong
changed the title
tintinthong
changed the base branch from
main
to
fix-component-cache-for-field
tintinthong
force-pushed
the
cs-7929-render-contained-example-in-spec
branch
from
0cf9e05 to
923e1a8
Compare
Currently, some issues with some fields. Color is another one |
|
Pause review here. There is some bug on primitive handling which requires more card-api tweaks |
The bug in here is when serializing (im not sure in deserializing) URL extends StringField. URL is a primitive so it doesn't serialize meta.fields. That means it doesn't have the ability to render a different template. |
tintinthong
force-pushed
the
fix-component-cache-for-field
branch
from
74384e1 to
332df0d
Compare
|
I have updated #2189. And will continue work once that is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on on #2189 and #2105.
Previously, Specs could not render fields
Now, Specs render fields based upon the code ref it contains
Further Note
Here, Specs are 1 to 1 with code refs so it doesn't really need a "different" subclass rendering of the field when showing containedExamples. However, if we want to include the UI affordance for selecting a template for field that is of a particular type, we can easily do so by dynamically specifying the typeConstraint (but this might not be the concern of Spec).
I saw some rendering thing with the ColorField. I'll look into it independently