Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update rust-version to 1.75.0 in Cargo.toml files #623

Merged
merged 19 commits into from
Mar 5, 2025

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Mar 4, 2025

Description


This PR bumps the MSRV to 1.75, previously this was 1.63 (the rust version of Debian stable), while being able to support the target of Debian stable at this point it is very old and forces use to use older deps especially for gRPC related dependencies this means we may not get the newest security updates and requires many deps to be pinned. BDK has bumped the msrv of their electrum crate for these reason as well as ldk-node, while I've previously said we should try to keep 1.63 causing us all headaches (sorry), with these projects bumping I think it makes sense for us to as well.

bitcoindevkit/bdk#1750

Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

@thesimplekid
Copy link
Collaborator Author

Since our msrv now supports workspace inheritance I've moved all out common deps to the workspace making it easier to ensure we don't have multiple versions. Also updates deps that were stuck on older version to to msrv ie axum tonic, swagger.

@thesimplekid thesimplekid marked this pull request as ready for review March 4, 2025 22:55
@thesimplekid thesimplekid merged commit e84d6ea into cashubtc:main Mar 5, 2025
65 checks passed
@thesimplekid thesimplekid added this to the v0.8.0 milestone Mar 5, 2025
@thesimplekid thesimplekid deleted the bump_msrv branch March 10, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants