-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update rust-version to 1.75.0 in Cargo.toml files #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok300
approved these changes
Mar 4, 2025
crodas
approved these changes
Mar 4, 2025
Since our msrv now supports workspace inheritance I've moved all out common deps to the workspace making it easier to ensure we don't have multiple versions. Also updates deps that were stuck on older version to to msrv ie axum tonic, swagger. |
ok300
reviewed
Mar 5, 2025
ok300
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the MSRV to 1.75, previously this was 1.63 (the rust version of Debian stable), while being able to support the target of Debian stable at this point it is very old and forces use to use older deps especially for gRPC related dependencies this means we may not get the newest security updates and requires many deps to be pinned. BDK has bumped the msrv of their electrum crate for these reason as well as ldk-node, while I've previously said we should try to keep 1.63 causing us all headaches (sorry), with these projects bumping I think it makes sense for us to as well.
bitcoindevkit/bdk#1750
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-check
before committing