-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for non-.nwb file extensions in NWB conversion for Converters and Interfaces #1228
base: main
Are you sure you want to change the base?
Conversation
…ters and Interfaces
What do you think of throwing an error instead of a warning? Reason being that nwb is already throwing a warning here and the library should follow good practices, right? |
Well I could imagine situations where someone might want to use another suffix. For example, they might want to have x.nwb.h5 and x.nwb.zarr to examine different compression strategies. But maybe this would break There is not a huge advantage of also having the warning here. One small advantage is instead of on |
Check this out: If the convention of having Taking into account all of this discussion I am leaning to just outsource this to upstream libraries. They already have a warning on place and that way we don't need to add extra logic here. Maybe we should update our dependencies to be at least the ones that have the warnings though. |
yeah that warning is recent and I think was just released today. I'd be fine with relying on that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 131 131
Lines 8411 8417 +6
=======================================
+ Hits 7564 7570 +6
Misses 847 847
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix #1212