New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching metadata in specs #117

Merged

xhocquet merged 1 commit into cburnette:master from JewelSam:fix-running-specs-metadata

Oct 31, 2022

Contributor

JewelSam commented Oct 29, 2022

Specs can't be ran, they fail with an error

Failure/Error: if test.metadata[:skip_reset]

ArgumentError:
  wrong number of arguments (given 0, expected 2..3)
# ./spec/spec_helper.rb:8:in `test'
# ./spec/spec_helper.rb:8:in `block (2 levels) in <top (required)>'

I'm not sure how it worked before but with this fix, metadata is fetching successfully.


          Fix fetching metadata in specs

a01281b

xhocquet approved these changes

View reviewed changes

Collaborator

xhocquet left a comment

Good catch, I'm not sure I've ever used this config before since a reset is recommended when running tests repeatedly.

xhocquet merged commit 43b4e0c into cburnette:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet