Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full RGB color thing is glitchy #166

Closed
cburschka opened this issue Feb 24, 2015 · 13 comments
Closed

Full RGB color thing is glitchy #166

cburschka opened this issue Feb 24, 2015 · 13 comments
Assignees
@cburschka
Labels
bug
Milestone
1.8 - Adagio

Comments

@cburschka
Copy link
Owner

It works properly once the RGB color has been set, but the "press for 0.5 seconds" thing doesn't seem to work right and requires a few attempts followed by clicking on the label itself. Tested in Firefox.
@cburschka cburschka added the bug label Feb 24, 2015
@cburschka cburschka self-assigned this Feb 24, 2015
@cburschka cburschka added this to the cadence 1.7 milestone Feb 24, 2015
@cburschka
Copy link
Owner Author

Current state model:

  • "None" state: Clicking on None brings up the palette both in full color mode and palette mode. Holding the button activates full color mode but does not open the color selector.
  • Color selected: Clicking on the color button brings up the palette in palette mode, and the selector in full color mode. Holding the button activates full color mode but does not open the selector.

So that's two bugs, kinda.

@cburschka
Copy link
Owner Author

Well, it's one bug, actually. Clicking on "None" intentionally opens the palette regardless of mode, because you can open the selector and cancel, which still leaves you in full color mode without a color set. You then couldn't go back to palette mode without first selecting a color and clearing it, which would be really weird.

The actual bug, of course, is that the selector doesn't open on the mouse-hold event in the first place.

@cburschka
Copy link
Owner Author

There is a second bug, in that if you are in phantom full-color mode, you can open the palette and select a color only once - clicking again will open the full color selector instead.

So full-color mode should be unset by selecting a palette color.

@cburschka
Copy link
Owner Author

There is also a third bug, which is that you can bring up the full color selector immediately by clicking the label.

This is due to the "for" attribute on the label. If it's set to textColor, then clicking the label does nothing (except briefly depress the button). Which is not ideal, but better than the current behavior.

@cburschka
Copy link
Owner Author

The latter two are easy to fix, but I'm pretty stumped by the first.

@cburschka
Copy link
Owner Author

For reference: http://stackoverflow.com/questions/28864557/triggering-a-click-event-in-a-timeout-function

@cburschka cburschka modified the milestones: cadence 1.8, cadence 1.7 Mar 28, 2015
@sylae
Copy link
Contributor

sylae commented Apr 17, 2015

Why not have an ellipsis or something at the end of the palette that opens the full-color selector? Or a dropdown triangle or some shit.

@cburschka
Copy link
Owner Author

That would actually be a good idea. Since the full-color setting is sticky (the only way to get back to the palette is to clear the setting) that extra click is really not significant.

@cburschka
Copy link
Owner Author

There is also a third bug, which is that you can bring up the full color selector immediately by clicking the label.

This is now fixed by #188.

@cburschka
Copy link
Owner Author

So full-color mode should be unset by selecting a palette color.

This is a one-line patch.

cburschka added a commit that referenced this issue Apr 29, 2015
@cburschka
Re #166: Unset fullColor on palette selection.
9a8fe46 
If no color is set, then fullColor mode is ignored, by design.
Selecting a palette color should then unset the mode, to avoid
surprisingly "switching" to fullColor mode (which has been active
all along) by selecting a color.
@cburschka
Copy link
Owner Author

Oops. Now I remember why I didn't put the control in the palette originally - it's not supposed to show up when you're using the [color] BBCode button.

@cburschka cburschka reopened this Apr 29, 2015
@cburschka
Copy link
Owner Author

Have to amend this slightly.

@cburschka cburschka reopened this Apr 29, 2015
@cburschka
Copy link
Owner Author

Silly github, reverting a commit with "Fix ..." in it should maybe reopen the issue, not close it. <_<

cburschka added a commit that referenced this issue May 8, 2015
@cburschka
Merge tag 'v1.8' into generic
fd1a32c 
"Adagio"
========

This update adds several major features and fixes many bugs, including a
security issue.

Critical bugs
-------------

- #192, #196: An arbitrary HTML/Javascript injection vulnerability was removed.
              The emoticon and URL-link processor used the obsolete
              jquery-replacetext library, which implicitly evaluated any escaped
              HTML code in messages as a side effect. The library has been
              removed and replaced with a more robust approach.

Features
--------

- #101: Rooms can be configured via arguments for /create or the newly added
        /configure command. This allows toggling room persistence, logging,
        permissions and other settings.

- #103: Direct messages can be sent and received via the /dmsg command. This
        allows sending a message directly to any JID (including across domains),
        and even to a specific client session identified by its resource.

- #167: Desktop notifications (if the browser and desktop environment support
        them) can be enabled for certain events when the client is in the
        background.

- #178: A list of navigational links can be inserted in the title bar.

- #182: The new /dnd command sets your status to "do not disturb", which turns
        off sounds and notifications, while also showing up as a status icon in
        the roster.

Bugs
----

- #142: All BBCode buttons now have shortcuts supported by most browsers,
        including Chromium-based ones that didn't work previously. These use
        the HTML5 accesskey attribute. The specific key combination may vary
        accross browsers, and is shown in the button tooltips.

- #166: The full RGB color selection now works reliably, by adding an "Advanced"
        button to the palette dialog that opens the color picker.

- #186: Disabling inline images now actually works, instead of showing both the
        image and the alt-text.

- #189: Emoticons will no longer render inside hyperlink anchors, which avoids
        rendering 8o or :D in URLs.

Minor fixes
-----------

- #179: Alphabetize /who output.
- #188: Some incorrect labels in the settings form have been fixed.
- #190: Open all links in new tab.
- #191: The text color RGB code is in monospace; the sliders have a set width.
- #195: JS libraries were updated (strophe, buzz, jquery and moment)
- #197: The codes in the help sidebar now line-wrap.
- #198: Some unused images have been removed, one image was renamed.
- #202: The stderr output of `which` is now suppressed.
- #203: The room title is no longer run through Strophe.unescapeNode
- #205: The onclick event for users is now attached instead of injected in HTML.
- #206: Private messages can now be sent to nicks that contain backslashes.
- #207: Pressing Escape or Cancel on the URL prompt no longer inserts [url][/url].
- #209: Make the recipient clickable on outgoing /msg and /dmsg whispers.
- #210: Some control flow refactoring.
cburschka added a commit to calref/cadence that referenced this issue May 9, 2015
@cburschka
Merge tag 'v1.8' into calref
01d816a 
"Adagio"
========

This update adds several major features and fixes many bugs, including a
security issue.

Critical bugs
-------------

- cburschka#192, cburschka#196: An arbitrary HTML/Javascript injection vulnerability was removed.
              The emoticon and URL-link processor used the obsolete
              jquery-replacetext library, which implicitly evaluated any escaped
              HTML code in messages as a side effect. The library has been
              removed and replaced with a more robust approach.

Features
--------

- cburschka#101: Rooms can be configured via arguments for /create or the newly added
        /configure command. This allows toggling room persistence, logging,
        permissions and other settings.

- cburschka#103: Direct messages can be sent and received via the /dmsg command. This
        allows sending a message directly to any JID (including across domains),
        and even to a specific client session identified by its resource.

- cburschka#167: Desktop notifications (if the browser and desktop environment support
        them) can be enabled for certain events when the client is in the
        background.

- cburschka#178: A list of navigational links can be inserted in the title bar.

- cburschka#180: Six new pony emotes have been added to the pack:
        :fluttersmile:, :ididntlisten:, :rdmad:, :shutup:, :symadder: :tavizero:

- cburschka#182: The new /dnd command sets your status to "do not disturb", which turns
        off sounds and notifications, while also showing up as a status icon in
        the roster.

Bugs
----

- cburschka#142: All BBCode buttons now have shortcuts supported by most browsers,
        including Chromium-based ones that didn't work previously. These use
        the HTML5 accesskey attribute. The specific key combination may vary
        accross browsers, and is shown in the button tooltips.

- cburschka#166: The full RGB color selection now works reliably, by adding an "Advanced"
        button to the palette dialog that opens the color picker.

- cburschka#186: Disabling inline images now actually works, instead of showing both the
        image and the alt-text.

- cburschka#189: Emoticons will no longer render inside hyperlink anchors, which avoids
        rendering 8o or :D in URLs.

Minor fixes
-----------

- cburschka#179: Alphabetize /who output.
- cburschka#188: Some incorrect labels in the settings form have been fixed.
- cburschka#190: Open all links in new tab.
- cburschka#191: The text color RGB code is in monospace; the sliders have a set width.
- cburschka#195: JS libraries were updated (strophe, buzz, jquery and moment)
- cburschka#197: The codes in the help sidebar now line-wrap.
- cburschka#198: Some unused images have been removed, one image was renamed.
- cburschka#202: The stderr output of `which` is now suppressed.
- cburschka#203: The room title is no longer run through Strophe.unescapeNode
- cburschka#205: The onclick event for users is now attached instead of injected in HTML.
- cburschka#206: Private messages can now be sent to nicks that contain backslashes.
- cburschka#207: Pressing Escape or Cancel on the URL prompt no longer inserts [url][/url].
- cburschka#209: Make the recipient clickable on outgoing /msg and /dmsg whispers.
- cburschka#210: Some control flow refactoring.

Conflicts:
	VERSION
	css/alt/dash/bolt.png
	img/lagging.png
	img/typing.png
	js/core/visual.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cburschka cburschka

Labels
bug
Projects
None yet
Milestone
1.8 - Adagio
Development

No branches or pull requests
2 participants
@cburschka @sylae