Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL fragment updating is broken #175

Closed
cburschka opened this issue Mar 27, 2015 · 0 comments
Closed

URL fragment updating is broken #175

cburschka opened this issue Mar 27, 2015 · 0 comments
Assignees
@cburschka
Labels
bug
Milestone
1.7 - Tirek

Comments

@cburschka
Copy link
Owner

1.) Parting a room doesn't always unset it
2.) Joining a room doesn't always update it
3.) When it does update it, there will be a space preceding the room name for some strange reason.
@cburschka cburschka added the bug label Mar 27, 2015
@cburschka cburschka self-assigned this Mar 27, 2015
@cburschka cburschka added this to the cadence 1.7 milestone Mar 27, 2015
cburschka added a commit to calref/cadence that referenced this issue Mar 29, 2015
@cburschka
Merge tag 'v1.7' into calref
5d97522 
"Tirek"
=======

This is a maintenance update that closes several substantial bugs in the
user interface.

Major
-----

- cburschka#144: Fix the user roster's removal function. It was currently deleting
        random users instead of the user that had actually left, messing up
        nickname sorting and occasionally failing to show a user logging in.

- cburschka#171: Ignore departures of unknown users. ejabberd sends multiple presence
        stanzas when a multi-session nick is kicked or banned, causing a crash
        when the roster tries to delete the same nick multiple times.

- cburschka#174: Escape usernames when generating a JID from a login name. This allows
        users with spaces or `"'<>&@\/:` characters to connect to a server.

Minor
-----

-       Restore the user sidebar's old width. It was made wider along with the
        emoticon sidebar.

- cburschka#154: Make the "hide inline images" setting hide only images. It was
        completely hiding every message received while active.

- cburschka#159: Restore messages to "inline" display after unhiding them, to avoid bad
        linebreaks.

- cburschka#161: Fix a Javascript error when running /save with empty chat history.

- cburschka#162: Don't play the "mention" sound for user's own login.

- cburschka#164: Remove font color from text box when persistent font colors are off.

- cburschka#165: Let delete button float at the top right corner of a message, rather
        than occasionally getting pushed below it.

- cburschka#169: Improve the join/part messages.

- cburschka#172: Refresh the room list before creating a room, to avoid phantom conflicts
        with deleted rooms, or actual conflicts with newly created ones.

- cburschka#173: Clear the room roster whenever a room is left. It was only cleared when
        switching directly between rooms.

- cburschka#175: Consistently update the URL fragment when leaving or joining rooms;
        fix a whitespace error when appending the URL fragment in /join.

- cburschka#176: Remove room name from page title when the room is left.

- cburschka#177: Unescape characters in usernames when rendering output. This is relevant
        when adding parentheses and generating CSS classes for flairs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cburschka cburschka

Labels
bug
Projects
None yet
Milestone
1.7 - Tirek
Development

No branches or pull requests
1 participant
@cburschka