Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle event errors. #430

Closed
cburschka opened this issue Sep 30, 2016 · 2 comments
Closed

Properly handle event errors. #430

cburschka opened this issue Sep 30, 2016 · 2 comments

Comments

@cburschka
Copy link
Owner

This was planned in #391:

These last two patches have finally added some exception handling to cadence.

Once they get introduced to the xmpp code as well (and specifically the event handlers), the client will no longer "crash" and we will finally (finally) have fixed the legendary #163 bug.

So this is where that happens.

@cburschka
Copy link
Owner Author

cburschka commented Sep 30, 2016

Since the handlers don't contain any asynchronous code, this shouldn't be much harder than wrapping them all in a try-catch block, sending errrors to Cadence.handleError() and returning true to strophe.

@cburschka
Copy link
Owner Author

Not only works like a charm, but also uncovered an error in the eventMessageError function that would have resulted in a silent #163 until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant