-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages are not displayed #163
Comments
To clarify, I am able to see the last twenty backlog messages in the chat when I log in; however, I know I'm not going to be able to see any /new/ messages if I've I've said something within the last twenty messages and it's missing when I log back in. |
What happens to local commands like Also, do you see anything in the Java console when config.settings.debug is set to 1 and you say something? |
I made a mistake in that post. I can get /ban messages and, presumably /version messages. |
https://gist.github.com/Nebedia/ba450436d9d69fc3017d |
I suspect this is confirmation:
This seems pretty weird. I'm not sure I'll make the Feb 28 milestone, but if I can fix this bug by then, I'll rush a 1.6.1 release. |
Okay, symptoms appear to be strictly limited to incoming messages (possibly including both groupchat and private messages, though it hasn't been reproduced with private messages as far as I can tell). The messages are clearly received by strophe, and appear in the debug stream, but are not printed. This implies that the problem should be one of these:
However, all of these problems should be either permanent or fixed by logging out and logging back in. I suspect I can't find out more without reproducing and actively debugging this issue... |
I also can't reproduce it in Firefox or Chromium, and it doesn't seem to be limited to a specific machine or a specific connection either. |
"However, all of these problems should be either permanent or fixed by logging out and logging back in." It would be helpful to have a clearer picture about whether mine is a cadence issue or something else on my end. But it doesn't appear anything else is affected when I can't see the chat. Additionally, my previous theories about memory leaks, BOINC interference, and other explanations are continually being proven false. The issue will will have a chance to happen even if the loading the chat is the first thing my computer does when it starts up and BOINC isn't running. |
So, I have some new information. "I know I'm not going to be able to see any /new/ messages if I've I've said something within the last twenty messages and it's missing when I log back in." Additionally: Could this be a memory leak issue? |
So, I've just determined that when I can't see my messages or incoming messages, I /will/ be able to see my PMs. (although not incoming PMs). Additionally, this problem can start merely by switching rooms, not just properly logging out. |
Yeah, outgoing PMs get displayed independently of the server, because On Sat, Mar 14, 2015 at 9:22 PM, Nebedia [email protected] wrote:
|
Today I briefly got a similar bug while working on #103 and changing some visual functions. It wasn't reproducible, and it affected all messages, not just those sent by users... but it simply dropped them without a JS error or interrupting XMPP traffic. If it keeps happening, I'd be interested if you could try out http://ermarian.net/cadence-1.8/#lounge and check the debug output there. |
Hm. In this case, just a syntax error, but I do have some ideas on what might be causing it, if it happens again. Expanding the condition to if (node != this.room.current)
+ var invite = $('x invite', stanza);
+ if (!resource && invite.length) {
+ var room = xmpp.room.available[node];
+ if (!room) xmpp.getRoomInfo(node, function(data) {
+ room = data;
+ xmpp.room.available[node] = data;
+ });
+ var reason = $('reason', invite).text();
+ ui.messageAddInfo(strings.info.inviteReceived[+!!reason], {
+ user: {jid: invite.attr('from')},
+ room: room,
+ reason: reason
+ });
+ }
return true; made it return all the time for messages from the MUC domain, because of the missing {} around the if block. This is not what caused the issue before, but it might indicate that the node / xmpp.room.current value are mismatched for some other reason, so all in-room messages get discarded. |
I'VE GOTTEN THE BUG. At first I thought my connection was being wonky, so I just refreshed. When I refreshed and it was still wonky, I realized IT'S HAPPENING. So yeah, I guess it can strike at any time, not just at login. First thing at the top of the console (after refresh): https://c312441.ssl.cf1.rackcdn.com/sylae/images/misc/860a0176087f1ee27409c013de34a1f3.png Presence changes show up in the chat, but not chat messages of any sort including direct messages. Of note, I am getting a few 'not well-formed' errors from time to time: https://c312441.ssl.cf1.rackcdn.com/sylae/images/misc/71d4d364493e220cd72cc42d40563c7f.png I will be leaving this browser session open and logged in, hopefully Aran can get with me after I get off work to nail this bug, once and for all. |
I HAVE THIS AGAIN In this case, I do get message elements appended to the chat pane, but they're set to opacity 0 for some reason. Edit: Fixed by closing and opening a new tab. |
I'm not sure if it's anything new, but I found a way to give oneself something like this bug (maybe actually this bug? I dunno) behold, https://gist.github.com/sylae/9566db2e3ade52e0ac16 |
The problem with this bug is that it's really just a crash that can happen
for any reason.
This particular crash seems to generate a message with no nick for some
reason; I'll investigate.
|
Has anyone had this happen lately? I can't remember the last time I got this bug. @nebedia says he hasn't seen it in 'forever'... |
I suppose a lot of the crash opportunities are gone now that the code is a bit more robust, so whatever caused it could've just disappeared. In 2.0, the error-handling is rewritten in a way that dumps JS errors onto the screen and (hopefully) avoids event handlers silently crashing. It's not complete, but once it is this shouldn't be an issue anymore. Guess I'll tentatively close this for now. |
Figured out a cause of this: I was dinking around on Conversations on my phone, and discovered I could set a subject for the room. This caused both myself and at least one other user to get Messages are not Displayed. Removing the subject via Pidgin (apparently I cannot do that on Conversations?) caused it to work on refresh |
I suspect a lot of the edge cases in the message handler (including subjects) should be fixed now, but I#ll test it when I get home. |
Yeah, I donno what did it, but this issue came back yesterday with a vengeance. I don't think chat messages are working for anyone at the current time. |
I'm gonna make a wild guess and say sy's experiment with the subject is in If I have time at the airport, I'll try to get a hotfix in so it stops -csb On Oct 6, 2016 7:30 PM, "Nebedia" [email protected] wrote:
|
Sudden crazy thought: If previous crashes were also caused by a message in On Oct 6, 2016 7:34 PM, "Christoph Burschka" [email protected] wrote:
|
I have a possible fix on The Other Branch here: calref#20 look fine to you to push? |
Okay, I'm back. Let's see... |
This is a strange issue, but one that I regularly have and I'm not entirely sure what's going on. I've been trying to determine whether this is a local issue or a problem with Cadence, but haven't made any interesting breakthroughs yet. Here's what I know.
Occasionally, when I log in, I get the following messages as normal:
(15:49:31) Ligrev: Automatically logging in as Neb
(15:49:31) Ligrev: Connecting ...
(15:49:33) Ligrev: You are now connected.
(15:49:33) Ligrev: Joining Ligrev's Lounge as Neb ...
(15:49:34) Ligrev: Now talking in Ligrev's Lounge.
(15:49:34) Ligrev: Neb logs into the Chat.
After this point, nothing else happens. Whether I say something, someone else says something, or I type /bans to get the chat itself to say something, nothing else displays on my end. That said, I can still speak and see updates to the conversation via the web-based chat log.
This issue will affect both Chrome (40.0.2214.111 m) and Firefox (35.0.1) at the same time, but NOT Internet Explorer (11.0.16).
So far, the only solution is to restart my entire computer. Hard refreshes etc. don't have an effect.
The text was updated successfully, but these errors were encountered: