Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address room ID collision issue #318

Open
nikolas opened this issue Feb 8, 2023 · 2 comments
Open

Address room ID collision issue #318

nikolas opened this issue Feb 8, 2023 · 2 comments

Comments

@nikolas
Copy link
Member

nikolas commented Feb 8, 2023

Currently, the "Make Room" procedure can overwrite existing rooms - the room ID is generated at random. Let's make sure the room is empty before using that ID for a new room.

Which begs the question - when and how are rooms made empty? The policy itself is very flexible - e.g. after a day or so of inactivity we can clean up room data. But how exactly will this happen on the technical side: a cron job? A celery task? Obviously, let's keep things as simple as possible.

@nikolas
Copy link
Member Author

nikolas commented Feb 8, 2023

Proposal by Evan: we have a user count in the room, we can catch the event where a room's population reaches 0, and consider that room to be "empty" and ready for cleanup.

I'll implement this and see how it feels.

@nikolas
Copy link
Member Author

nikolas commented Feb 9, 2023

Although emptying the room when everyone leaves may be slightly simpler on the technical side, it sounds like what we want is a timed time-out. So, I'll set something up to clear the room after 24 hours of inactivity, to start.

nikolas added a commit that referenced this issue Feb 23, 2023
@nikolas nikolas changed the title Address room collision issue Address room ID collision issue Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant