-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP: Add Hyperlane protocol #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from nit in table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ty. Added a few optional suggestions
cips/cip-add-hyperlane.md
Outdated
|
||
### Detailed Design | ||
|
||
Hyperlane on Celestia, more concretely, requires the addition of two SDK modules: `x/core` and `x/warp`. These are imported from https://github.com/bcp-innovations/hyperlane-cosmos. Token transfer will be enabled upon upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional]
Hyperlane on Celestia, more concretely, requires the addition of two SDK modules: `x/core` and `x/warp`. These are imported from https://github.com/bcp-innovations/hyperlane-cosmos. Token transfer will be enabled upon upgrade. | |
Hyperlane on Celestia, more concretely, requires the addition of two SDK modules: `x/core` and `x/warp`. These are imported from https://github.com/bcp-innovations/hyperlane-cosmos. These two modules will be added in the next upgrade which will enable token transfers to other Hyperlane enabled chains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence refers to an actual parameter that needs to be set to actually switch on token transfers. Maybe that wasn't clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that wasn't clear. Which parameter needs to be set?
cips/cip-add-hyperlane.md
Outdated
|
||
## Motivation | ||
|
||
Hyperlane is a popular bridging protocol that has support for EVM, currently the most popular VM for Celestia Rollups, as well as several others, creating connections between some 130 networks. Hyperlane is already employed indirectly to transfer TIA around but is dependent on third party networks, expanding the trust assumptions. Adding Hyperlane natively allows for direct transferring of TIA and possibly other tokens in the future without expanding the trust assumptions beyond the DA network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional] added a few sentences about how Hyperlane differs from IBC and why that might be part of the motivation here.
Hyperlane is a popular bridging protocol that has support for EVM, currently the most popular VM for Celestia Rollups, as well as several others, creating connections between some 130 networks. Hyperlane is already employed indirectly to transfer TIA around but is dependent on third party networks, expanding the trust assumptions. Adding Hyperlane natively allows for direct transferring of TIA and possibly other tokens in the future without expanding the trust assumptions beyond the DA network. | |
The only bridging protocol currently deployed on Celestia is IBC. Hyperlane is a widely used bridging protocol that supports EVM—the most popular virtual machine for Celestia Rollups—as well as several other environments. Since IBC doesn't currently support EVM chains, adding Hyperlane to Celestia will enable connections to 100+ networks, many of which are not serviced by IBC. Currently, Hyperlane is used indirectly to transfer TIA, but it relies on third-party networks, which increases trust assumptions. Integrating Hyperlane natively would enable direct transfers of TIA, and potentially other tokens in the future, without expanding trust assumptions beyond the DA network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK about the 130 network number because the Hyperlane website claims 100+ and the Hyperlane registry has 108 chains listed.
Ref:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got this number from Jacob. I don't mind replacing it with 100+ - I guess the idea is just to explain the extent of it's connectivity
Co-authored-by: Josh Stein <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
It looks like this was merged without assigning a CIP number and adding it to the table of contents. Do you mind doing that @rootulp when you get a moment? |
Supersedes: #256
Rendered