feat: version gate MsgExec limit #4373
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
reviewed
Mar 4, 2025
Comment on lines
+49
to
+62
| // Try to determine the app version or use latest | ||
| appVersion := getAppVersion(logger, db) | ||
|
|
||
| // Create the appropriate encoding configuration based on the app version | ||
| var encodingConfig encoding.Config | ||
| if appVersion < v3.Version { | ||
| // For versions 1 and 2, use the standard encoding config without recursion limits | ||
| logger.Info("Using standard encoding config without recursion limits", "app_version", appVersion) | ||
| encodingConfig = encoding.MakeConfig(app.ModuleEncodingRegisters...) | ||
| } else { | ||
| // For version 3+, use the versioned encoding config with recursion limits | ||
| logger.Info("Using versioned encoding config with recursion limits", "app_version", appVersion) | ||
| encodingConfig = encoding.MakeVersionedConfig(appVersion, app.ModuleEncodingRegisters...) | ||
| } |
There was a problem hiding this comment.
would this work as expected? If I only start up once, then I would be using the encodingConfig for version 1 even if I eventually sync up to a height with app version 3 or greater
There was a problem hiding this comment.
I had the same concern. This needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4370