Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set useShareIndexes=true in availability_test.go #1231

Open
rootulp opened this issue Oct 13, 2022 · 0 comments
Open

Set useShareIndexes=true in availability_test.go #1231

rootulp opened this issue Oct 13, 2022 · 0 comments
Labels
area:core_and_app Relationship with Core node and Celestia-App kind:testing Related to unit tests

Comments

@rootulp
Copy link
Contributor

rootulp commented Oct 13, 2022

Context

In celestia-app 0.7.0, there is a breaking change to the shares.Split.

This issue is a follow-up TODO from #1147

Problem

Unit tests in share/availability/light/availability_test.go currently set useShareIndexes=false because useShareIndexes=true will break unit tests unless we also update the transaction data used by tests to contain share indexes. This is non-trivial because the sample block used in the tests doesn't contain share indexes:

// this is a sample block from devnet-2 which originally showed the issue with share ordering
//
//go:embed "testdata/block-825320.json"
var sampleBlock string

Proposal

  1. Update transaction data in test to contain share indexes
  2. Set useShareIndexes=true
  3. Remove TODO comment
@rootulp rootulp added area:core_and_app Relationship with Core node and Celestia-App kind:testing Related to unit tests labels Oct 13, 2022
evan-forbes added a commit that referenced this issue Oct 14, 2022
Closes #1142
Opens #1231

Co-authored-by: evan-forbes <[email protected]>
Co-authored-by: rene <[email protected]>
tzdybal pushed a commit to celestiaorg/go-header that referenced this issue Dec 7, 2022
Wondertan pushed a commit to celestiaorg/go-fraud that referenced this issue Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core_and_app Relationship with Core node and Celestia-App kind:testing Related to unit tests
Projects
None yet
Development

No branches or pull requests

1 participant