Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions #1467

Merged
merged 39 commits into from
Mar 5, 2021
Merged

Github actions #1467

merged 39 commits into from
Mar 5, 2021

Conversation

vedhavyas
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #1467 (c811a39) into develop (2b2e892) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1467      +/-   ##
===========================================
+ Coverage    66.62%   66.67%   +0.04%     
===========================================
  Files          131      130       -1     
  Lines         8357     8306      -51     
===========================================
- Hits          5568     5538      -30     
+ Misses        2170     2152      -18     
+ Partials       619      616       -3     
Impacted Files Coverage Δ
notification/notification.go 42.10% <100.00%> (+3.21%) ⬆️
contextutil/context.go 20.58% <0.00%> (-8.58%) ⬇️
errors/stack.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2e892...c811a39. Read the comment docs.

@vedhavyas vedhavyas force-pushed the feat/gh_actions branch 17 times, most recently from 306de74 to b3c2de3 Compare March 1, 2021 13:38
@vedhavyas vedhavyas force-pushed the feat/gh_actions branch 6 times, most recently from fcf072a to 43794a3 Compare March 1, 2021 16:23
@vedhavyas vedhavyas requested a review from mikiquantum March 5, 2021 14:25
@vedhavyas vedhavyas force-pushed the feat/gh_actions branch 2 times, most recently from df75d08 to d32d7a4 Compare March 5, 2021 20:11
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool @vedhavyas !

@@ -58,8 +41,9 @@ generate: ## autogenerate go files for config
go generate ./config/configuration.go

install-subkey: ## installs subkey
curl https://getsubstrate.io -sSf | bash -s -- --fast
cargo install --force --git https://github.com/paritytech/substrate subkey
wget -P ${HOME}/.cargo/bin/ https://storage.googleapis.com/centrifuge-dev-public/subkey-rc6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that this will only work for a linux distribution, prob not for macOS, in which case cargo install would still help to keep in, although we are going to start using go-subkey-port so, might not be needed at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is TODO yet. i'm not able to upgrade the gsrpc because for latest go-ethereum issue. Once that is fixed, mac os should run natively. Until then, we anyway throw a helpful error so its easy to identify the cause

@@ -10,7 +10,7 @@ import (
var gitCommit = "master"

// CentrifugeNodeVersion is the current version of the app
const CentrifugeNodeVersion = "1.0.0"
const CentrifugeNodeVersion = "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 nice.

go-version: [1.15.x]
#TODO(ved): enable macos once we port to go-subkey on gsrpc
os: [ubuntu-latest]
test: [unit, cmd, integration, testworld]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these run in parallel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap

runs-on: ${{ matrix.os }}
env:
GOPATH: ${{ github.workspace }}
SWAGGER_API_KEY: ${{ secrets.swagger_api_key }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are these secrets configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github secrets. they are decrypted transparently only pushed to develop or master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should be present under project settings

@vedhavyas vedhavyas merged commit 014d10f into develop Mar 5, 2021
@vedhavyas vedhavyas deleted the feat/gh_actions branch March 5, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants