-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions #1467
Github actions #1467
Conversation
0d6d01a
to
53edbb6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1467 +/- ##
===========================================
+ Coverage 66.62% 66.67% +0.04%
===========================================
Files 131 130 -1
Lines 8357 8306 -51
===========================================
- Hits 5568 5538 -30
+ Misses 2170 2152 -18
+ Partials 619 616 -3
Continue to review full report at Codecov.
|
306de74
to
b3c2de3
Compare
b3c2de3
to
d73da60
Compare
fcf072a
to
43794a3
Compare
5bd3357
to
a799313
Compare
ab67cdd
to
fe8001b
Compare
fe8001b
to
ce5182f
Compare
fb0ab0a
to
a3be669
Compare
df75d08
to
d32d7a4
Compare
d32d7a4
to
c811a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool @vedhavyas !
@@ -58,8 +41,9 @@ generate: ## autogenerate go files for config | |||
go generate ./config/configuration.go | |||
|
|||
install-subkey: ## installs subkey | |||
curl https://getsubstrate.io -sSf | bash -s -- --fast | |||
cargo install --force --git https://github.com/paritytech/substrate subkey | |||
wget -P ${HOME}/.cargo/bin/ https://storage.googleapis.com/centrifuge-dev-public/subkey-rc6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that this will only work for a linux distribution, prob not for macOS, in which case cargo install would still help to keep in, although we are going to start using go-subkey-port so, might not be needed at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is TODO yet. i'm not able to upgrade the gsrpc because for latest go-ethereum issue. Once that is fixed, mac os should run natively. Until then, we anyway throw a helpful error so its easy to identify the cause
@@ -10,7 +10,7 @@ import ( | |||
var gitCommit = "master" | |||
|
|||
// CentrifugeNodeVersion is the current version of the app | |||
const CentrifugeNodeVersion = "1.0.0" | |||
const CentrifugeNodeVersion = "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 nice.
go-version: [1.15.x] | ||
#TODO(ved): enable macos once we port to go-subkey on gsrpc | ||
os: [ubuntu-latest] | ||
test: [unit, cmd, integration, testworld] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these run in parallel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap
runs-on: ${{ matrix.os }} | ||
env: | ||
GOPATH: ${{ github.workspace }} | ||
SWAGGER_API_KEY: ${{ secrets.swagger_api_key }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are these secrets configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github secrets. they are decrypted transparently only pushed to develop or master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they should be present under project settings
No description provided.