Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrifuge chain NFT #1469

Merged
merged 12 commits into from
Mar 22, 2021
Merged

Centrifuge chain NFT #1469

merged 12 commits into from
Mar 22, 2021

Conversation

vedhavyas
Copy link
Contributor

@vedhavyas vedhavyas commented Mar 10, 2021

This PR brings the following changes:

Next:

  • Once the above PRs are in and this one merged, one more PR to add the HTTP endpoints with testworld tests connecting the service functions we defined here

PS: Please ensure you have reviewed the above PR before reviewing this PR for context. Thanks!

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1469 (06eb9ae) into develop (b3995b9) will increase coverage by 0.37%.
The diff coverage is 65.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1469      +/-   ##
===========================================
+ Coverage    66.69%   67.06%   +0.37%     
===========================================
  Files          130      130              
  Lines         8301     8525     +224     
===========================================
+ Hits          5536     5717     +181     
+ Misses        2149     2138      -11     
- Partials       616      670      +54     
Impacted Files Coverage Δ
documents/entity/model.go 70.10% <0.00%> (ø)
documents/entityrelationship/model.go 74.26% <ø> (ø)
documents/generic/model.go 50.79% <0.00%> (ø)
nft/nft.go 47.36% <ø> (ø)
nft/chain_api.go 53.91% <42.69%> (-38.68%) ⬇️
centchain/api.go 73.56% <57.89%> (+23.56%) ⬆️
nft/service.go 68.18% <75.43%> (-0.61%) ⬇️
nft/jobs.go 72.06% <78.21%> (-0.19%) ⬇️
anchors/service.go 53.19% <100.00%> (ø)
documents/read_acls.go 80.64% <100.00%> (+0.23%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3995b9...06eb9ae. Read the comment docs.

@vedhavyas vedhavyas force-pushed the feat/cc_nft branch 3 times, most recently from efd3708 to 39add30 Compare March 12, 2021 23:29
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vedhavyas !

@vedhavyas vedhavyas merged commit a3edfd3 into develop Mar 22, 2021
@vedhavyas vedhavyas deleted the feat/cc_nft branch March 22, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants