Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust test wrapper to just create env #1473

Merged
merged 6 commits into from
Apr 6, 2021
Merged

adjust test wrapper to just create env #1473

merged 6 commits into from
Apr 6, 2021

Conversation

vedhavyas
Copy link
Contributor

@vedhavyas vedhavyas commented Mar 24, 2021

Thi PR:

  • Adds make commands to run and stop local environment, create testing config, and run node using that config
  • Scripts cleanup using shellcheck

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #1473 (bf0bc1f) into develop (f8fe3a0) will decrease coverage by 0.10%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1473      +/-   ##
===========================================
- Coverage    67.29%   67.19%   -0.11%     
===========================================
  Files          131      131              
  Lines         8665     8681      +16     
===========================================
+ Hits          5831     5833       +2     
- Misses        2154     2168      +14     
  Partials       680      680              
Impacted Files Coverage Δ
migration/files/02AddPrefix.go 66.66% <0.00%> (ø)
migration/wrapper.go 60.43% <ø> (ø)
utils/httputils.go 23.07% <0.00%> (+3.07%) ⬆️
cmd/centrifuge/create_config.go 33.33% <12.50%> (-1.29%) ⬇️
contextutil/context.go 20.58% <0.00%> (-8.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fe3a0...bf0bc1f. Read the comment docs.

@vedhavyas vedhavyas marked this pull request as ready for review April 1, 2021 13:11
@vedhavyas vedhavyas requested a review from mikiquantum April 1, 2021 13:13
@vedhavyas vedhavyas merged commit ff0fc47 into develop Apr 6, 2021
@vedhavyas vedhavyas deleted the feat/local-env branch April 6, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant