removing zk tree usage #1529
Merged
removing zk tree usage #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v1.4.0 #1529 +/- ##
===========================================
+ Coverage 40.79% 65.44% +24.65%
===========================================
Files 9 131 +122
Lines 201 9858 +9657
===========================================
+ Hits 82 6452 +6370
- Misses 112 2820 +2708
- Partials 7 586 +579
Continue to review full report at Codecov.
|
cdamian
reviewed
Jun 20, 2022
NunoAlexandre
approved these changes
Jun 20, 2022
| @@ -280,7 +281,7 @@ func Test_getBundledHash(t *testing.T) { | |||
| byteSliceToByteArray32(common.FromHex("0xed58f4a0d0c76770c81d2b1cc035413edebb567f5c006160596dc73b9297a9cc")), | |||
| } | |||
|
|
|||
| bh := common.FromHex("0xee49e1ca6aa1204cfb571094ce14ab254e5185005cbee3f26af9afd3140ac12d") | |||
| bh := common.FromHex("0xbbf0c526070f3b823eb995aa31f2ac9635532a0b010ff27183be7bf25b3f002a") | |||
There was a problem hiding this comment.
Since we changed from using keccak to using blake2b the hash changed. In any case, this code most likely will not be used once we move all pools to the chain.
| @@ -104,17 +105,16 @@ func AssetDir(name string) ([]string, error) { | |||
| } | |||
|
|
|||
| type _bintree_t struct { | |||
| Func func() ([]byte, error) | |||
| Func func() ([]byte, error) | |||
There was a problem hiding this comment.
Suggested change
| Func func() ([]byte, error) | |
| Func func() ([]byte, error) |
There was a problem hiding this comment.
This is autogenerated code, and rather not lint it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1519