Default error message #32
Conversation
jmsv6d
requested review from
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
translations/en-AU.json
Outdated
| @@ -4,5 +4,6 @@ | |||
| "terraApplication.unsavedChangesPrompt.multiplePromptMessageIntro": "There are unsaved changes made to the following:", | |||
| "terraApplication.unsavedChangesPrompt.multiplePromptMessageOutro": "Changes will be lost if you don't save them. How do you want to proceed?", | |||
| "terraApplication.unsavedChangesPrompt.acceptButtonText": "Don't Save", | |||
| "terraApplication.unsavedChangesPrompt.rejectButtonText": "Continue Editing" | |||
| "terraApplication.unsavedChangesPrompt.rejectButtonText": "Continue Editing", | |||
| "terraApplication.errorBoundary.defaultErrorMessage": "We are currently unable to complete your request. Try again later, and contact your support team if this problem continues." | |||
There was a problem hiding this comment.
I'm not sure these error boundary failures are the types of failures that will just work if you try again. Something massively went wrong in your application.
| return ( | ||
| <StatusView | ||
| variant="error" | ||
| message={activeError.toString()} | ||
| message={errorText} |
There was a problem hiding this comment.
Could I get some more information about why we're changing the error boundary text? What cases are they being used for? I assumed they would be here in the case of major app failures. Are people seeing these a lot?
There was a problem hiding this comment.
If there's an error thrown without any error message, then the error view will display the error type without any indication to the user about what went wrong. This would provide some sort of information to the user in that case. This would likely only happen if a custom error was thrown that didn't provide any message and was not caught anywhere.
There was a problem hiding this comment.
Have we seen instances where the thrown js exception doesn't have an error message? I don't mean to be difficult but I wondering what brought this change up?
There was a problem hiding this comment.
@mjhenkes, UX didn't like it. Didn't think it was user friendly
|
@ryanthemanuel: Discussed with the UXFoundations group, and there are potentially two versions depending on the use case I'll detail out below. Our traditional messaging when errors are present is to state what the issue is and how to resolve it. Typically and whenever possible, we would offer actions to the user to retry, log a ticket, or when no action is available to contact their system admin/IT support. Based on my conversations with Ryan this situation will only occur in non-prod environments where only an engineer or developer would encounter them, not a user (ie: clinician, revcycle staff, etc.) If this is the case where the user would know by using the error tracing what to correct. Our proposal is outlined below. please let me know if any assumptions are incorrect. Scenario 1: Error messaging is short & concise, less than 2 lines of text.
Scenario 2: Error messaging is long & has lots of coding jargon.
|
|
@jmsv6d let's go with scenario 1 here for now. I've logged cerner/terra-core#3000 to let us explore doing something more along the lines of scenario 2 with the status view. |
|
Since you added the new issue, can we remove the UX review label on this one? |
# Conflicts: # CONTRIBUTORS.md
# Conflicts: # CONTRIBUTORS.md # src/application-error-boundary/ApplicationErrorBoundary.jsx
Summary
Adding a default error message for the error boundary when there is none provided
Deployment Link
https://terra-applic-default-er-qucogs.herokuapp.com/tests/terra-application/application-error-boundary/error-boundary-test
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra