This repository was archived by the owner on May 24, 2024. It is now read-only.
[terra-time-input] Remove placeholder #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav300
requested review from
supreethmr,
lokesh-0813,
saket2403,
ShettyAkarsh and
avinashg1994
pranav300
requested review from
benbcai,
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
There was a problem hiding this comment.
Should these tests be updated to test accessibility now as well? https://github.com/cerner/terra-framework/blob/main/packages/terra-time-input/tests/wdio/time-input-twelve-hour-spec.js#L5
benbcai
reviewed
Sep 10, 2020
| @@ -825,6 +831,9 @@ class TimeInput extends React.Component { | |||
| /> | |||
| </ButtonGroup> | |||
| )} | |||
| <div id={formatDescriptionId} className={cx('format-text')} aria-label={`Time Format: ${format}`}> | |||
There was a problem hiding this comment.
"Time Format:" should probably be translated.
There was a problem hiding this comment.
Raised jira for translations.
jeremyfuksa
added
⭐ Accessibility Reviewed
⭐ UX Reviewed
neilpfeiffer
added
UX Review Required
and removed
⭐ UX Reviewed
lokesh-0813
approved these changes
Sep 14, 2020
…erner/terra-framework into date-time-picker-demo
…om/cerner/terra-framework into date-time-picker-demo
…erner/terra-framework into date-time-picker-demo
|
Tested: PR #1235 Reviewed:
|
neilpfeiffer
added
⭐ UX Reviewed
ryanthemanuel
approved these changes
Sep 14, 2020
… remove-placeholder-from-time-input
Yes, updated the tests here df91b79 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR
Removes placeholder from the input.
Adds format to be displayed under the time-input.
Edit: Removed themeable variable
--terra-time-input-meridiem-button-group-margin-bottomCloses #1193
Deployment Link
https://terra-framew-remove-pla-jmtcda.herokuapp.com/components/terra-time-input/time-input/time-input
Testing
Additional Details
Time Input:
12-hour
time input:
Thank you for contributing to Terra.
@cerner/terra