This repository was archived by the owner on May 24, 2024. It is now read-only.
[terra-date-picker] Remove placeholder #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav300
requested review from
supreethmr,
lokesh-0813,
saket2403,
ShettyAkarsh and
avinashg1994
pranav300
requested review from
benbcai,
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
mjhenkes
approved these changes
Sep 11, 2020
benbcai
reviewed
Sep 11, 2020
| @@ -222,13 +229,25 @@ const DatePickerField = (props) => { | |||
| mergedInputAttrs = { 'aria-describedby': ariaDescriptionIds, ...inputAttributes }; | |||
| } | |||
|
|
|||
| const helpLabel = help ? ( | |||
| <div id="format" aria-label={`Date Format: ${intl.formatMessage({ id: 'Terra.datePicker.dateFormat' })}, ${help}`}> | |||
There was a problem hiding this comment.
Should this id also be randomized like the other places?
There was a problem hiding this comment.
The field component doesn't require a description id as they internally provide helpDescriptionIds. I had format just to give that div an id.
ShettyAkarsh
approved these changes
Sep 11, 2020
benbcai
reviewed
Sep 11, 2020
| @@ -20,6 +21,11 @@ const propTypes = { | |||
| * Callback ref to pass into the calendar button dom element. | |||
| */ | |||
| buttonRefCallback: PropTypes.func, | |||
| /** | |||
| * @private | |||
| * To check if help element is provided by the field or not. | |||
There was a problem hiding this comment.
Suggested change
| * To check if help element is provided by the field or not. | |
| * NOTICE: Internal prop to be used only by Terra framework. This component provides a built-in format mask that is required to be displayed to users for proper accessibility and must not be removed. 'DatePickerField' is permitted to set this prop because it provides the same format mask in its 'help' prop. |
Suggestion to switch propType to a boolean, default to false, and update prop name (e.g. useExternalFormatMask)
There was a problem hiding this comment.
Updated here 80414a5. And added translations
benbcai
reviewed
Sep 11, 2020
benbcai
approved these changes
Sep 11, 2020
jeremyfuksa
approved these changes
Sep 11, 2020
jeremyfuksa
added
⭐ UX Reviewed
neilpfeiffer
added
UX Review Required
and removed
⭐ UX Reviewed
|
Tested: PR #1239 Reviewed:
|
neilpfeiffer
added
⭐ UX Reviewed
ryanthemanuel
approved these changes
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR
DatePickerandDatePickerField.Link: jira for translations.
A part of #1193
Deployment Link
https://terra-framework-deployed-pr-#.herokuapp.com/
Testing
Date Picker:
Date Picker Field:
Additional Details
Thank you for contributing to Terra.
@cerner/terra