Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize src and _mobileSrc properties #16

Closed
swashbuck opened this issue May 3, 2023 · 1 comment · Fixed by #28
Closed

Standardize src and _mobileSrc properties #16

swashbuck opened this issue May 3, 2023 · 1 comment · Fixed by #28
Assignees
@guywillis
Labels
breaking enhancement needs migration released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented May 3, 2023 •
edited
Loading

Subject of the issue

The src and _mobileSrc properties should be standardized.

  1. src is not translatable and should therefore have an underscore before it (ex. _src).
  2. However, since these properties relate to breakpoints, we should probably use _small and _large.

Suggest changing this to:

"_graphic": {
    "_large": "assets/example.png",
    "_small": "",
    "alt": ""
},

Will need migration scripts.
@swashbuck swashbuck changed the title Standardize src and _mobileSrc property Standardize src and _mobileSrc properties May 3, 2023
@swashbuck swashbuck mentioned this issue May 3, 2023
Merged
@guywillis guywillis self-assigned this Jul 4, 2024
@guywillis guywillis mentioned this issue Jul 4, 2024
Merged
github-actions bot pushed a commit that referenced this issue Jul 15, 2024
@semantic-release-bot
Chore(release): 4.0.0 [skip ci]
0166582 
# [4.0.0](v3.3.0...v4.0.0) (2024-07-15)

### Breaking

* Core image template update (fixes #16) ([4cf9197](4cf9197)), closes [#16](#16)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
breaking enhancement needs migration released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: Core image template update (fixes #16) cgkineo/adapt-navigationLogo
3 participants
@swashbuck @kirsty-hames @guywillis