Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename _isHidden to _isHiddenOnMenu #17

Closed
guywillis opened this issue Jun 28, 2023 · 1 comment · Fixed by #18
Closed

Rename _isHidden to _isHiddenOnMenu #17

guywillis opened this issue Jun 28, 2023 · 1 comment · Fixed by #18
Assignees
@swashbuck
Labels
breaking enhancement released

Comments

@guywillis
Copy link
Contributor

Subject of the issue

The recent introduction of the config option _isHidden is potentially a little vague and does not specifically describe where the navigation logo is being hidden.

Similarly, a sibling config option _isEnabled describes pretty much the same functionality as _isHidden even though they have separate purposes.

Your environment

  • Master

Expected behaviour

Perhaps changing the name of the _isHidden property to _isHiddenOnMenu would help describe the functionality of the config option more precisely.
@guywillis guywillis mentioned this issue Jun 28, 2023
Merged
@swashbuck swashbuck self-assigned this Aug 22, 2023
@swashbuck swashbuck mentioned this issue Aug 22, 2023
Merged
oliverfoster added a commit that referenced this issue Aug 24, 2023
@oliverfoster
Update: Rename isHidden property to isHiddenOnMenu for clarity (fixes #…
54e2a63 
…17)
github-actions bot pushed a commit that referenced this issue Aug 24, 2023
@semantic-release-bot
Chore(release): 3.1.0 [skip ci]
fd221b8 
# [3.1.0](v3.0.3...v3.1.0) (2023-08-24)

### Update

* Rename isHidden property to isHiddenOnMenu for clarity (fixes #17) ([54e2a63](54e2a63)), closes [#17](#17)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
breaking enhancement released
Projects
None yet
Milestone
No milestone
3 participants
@swashbuck @kirsty-hames @guywillis